Merge all core codegen into FBReactNativeSpec #50317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
javache
changed the title
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 27, 2025
Summary: Pull Request resolved: facebook#50317 Pull Request resolved: facebook#43570 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
javache
force-pushed
the
export-D55037569
branch
from
2e29b34 to
98be50d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
javache
force-pushed
the
export-D55037569
branch
from
98be50d to
2c0ff64
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 27, 2025
Summary: Pull Request resolved: facebook#50317 Pull Request resolved: facebook#43570 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
javache
added a commit
to javache/react-native
that referenced
this pull request
May 27, 2025
Summary: Pull Request resolved: facebook#50317 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
javache
added a commit
to javache/react-native
that referenced
this pull request
May 29, 2025
Summary: Pull Request resolved: facebook#50317 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
javache
added a commit
to javache/react-native
that referenced
this pull request
May 30, 2025
Summary: Pull Request resolved: facebook#50317 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Differential Revision: D55037569
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jun 2, 2025
Summary: Pull Request resolved: facebook#50317 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D55037569
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jun 2, 2025
Summary: Pull Request resolved: facebook#50317 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D55037569
Summary: Pull Request resolved: facebook#50317 `rncore`, `FBReactNativeSpec` and `FBReactNativeComponentSpec` contain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize on `FBReactNativeSpec` everywhere. I've left the Android OSS targets names as is, to avoid breaking deps. This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D55037569
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55037569 |
Contributor
|
This pull request has been merged in 95ed8a6. |
Collaborator
|
This pull request was successfully merged by @javache in 95ed8a6 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
rncore,FBReactNativeSpecandFBReactNativeComponentSpeccontain the same symbols, which leads to conflicts when we try to merge them into a single shared library. Cleanup the duplication and standardize onFBReactNativeSpeceverywhere. I've left the Android OSS targets names as is, to avoid breaking deps.This aligns react-native's package.json with the codegen tooling supported across iOS and Android, which is a single target for all all type-derived codegen.
Changelog: [Breaking] Please update references to rncore headers with FBReactNativeSpec
Differential Revision: D55037569