Implement prop diffing for transform props in <View> #48832
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59972039 |
mdvacca
force-pushed
the
export-D59972039
branch
from
405488f to
ad45882
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59972039 |
mdvacca
force-pushed
the
export-D59972039
branch
from
ad45882 to
f0386f2
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 22, 2025
Summary: This diff implements the diffing for transform props of <View> changelog: [internal] internal Reviewed By: javache Differential Revision: D59972039
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59972039 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 22, 2025
…ook#48832) Summary: This diff implements the diffing for transform props of <View> changelog: [internal] internal Reviewed By: javache Differential Revision: D59972039
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 22, 2025
…ook#48832) Summary: This diff implements the diffing for transform props of <View> changelog: [internal] internal Reviewed By: javache Differential Revision: D59972039
Summary: In this diff I'm overriding the getDiffProps for ViewProps. The goal is to verify what's the impact of calculating diffs of props in Android, starting with ViewProps. Once we verify what are the implication we will automatic implement this diffing. The full implementation of this method will be implemented in the following diffs changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D59969328
…48829) Summary: This diff implements the diffing for basic props of <View> changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D59972040
…48830) Summary: This diff implements the diffing for event props of <View> changelog: [internal] internal Reviewed By: javache Differential Revision: D59972038
…#48831) Summary: This diff implements the diffing for border props of <View> changelog: [internal] internal Reviewed By: sammy-SC Differential Revision: D59972037
Summary: This diff implements the diffing for transform props of <View> changelog: [internal] internal Reviewed By: javache Differential Revision: D59972039
mdvacca
force-pushed
the
export-D59972039
branch
from
f0386f2 to
3f3478a
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 22, 2025
…ook#48832) Summary: This diff implements the diffing for transform props of <View> changelog: [internal] internal Reviewed By: javache Differential Revision: D59972039
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59972039 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 22, 2025
…ook#48832) Summary: This diff implements the diffing for transform props of <View> changelog: [internal] internal Reviewed By: javache Differential Revision: D59972039
Contributor
|
This pull request has been merged in 2e8720a. |
This was referenced May 27, 2025
Closed
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
Summary: Pull Request resolved: facebook#48832 This diff implements the diffing for transform props of <View> changelog: [internal] internal Reviewed By: javache Differential Revision: D59972039 fbshipit-source-id: e4c3beff4c6411595ab83ff62b54b948f9337851
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff implements the diffing for transform props of
changelog: [internal] internal
Reviewed By: javache
Differential Revision: D59972039