CMake Windows path normalization #47702
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Use `file(TO_CMAKE_PATH` to normalize paths, and normalizing `input_SRC` as it's already a CMake path. Changelog: [Internal] Reviewed By: rshest Differential Revision: D66101321
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66101321 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66101321 |
Contributor
|
This pull request has been merged in 13bc4a2. |
Collaborator
|
This pull request was successfully merged by @blakef in 13bc4a2 When will my fix make it into a release? | How to file a pick request? |
blakef
added a commit
that referenced
this pull request
Nov 21, 2024
Summary: Pull Request resolved: #47702 Use `file(TO_CMAKE_PATH` to normalize paths, and normalizing `input_SRC` as it's already a CMake path. Changelog: [Internal] Reviewed By: rshest Differential Revision: D66101321 fbshipit-source-id: e81af40551d2777901f9c7cf9a4175f2bce76ec8
This was referenced Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Use
file(TO_CMAKE_PATHcommand to normalize paths. Normalizinginput_SRCas it's already a CMake-style path outputted by thefile(GLOBcommand.Changelog: [Internal]
Reviewed By: rshest
Differential Revision: D66101321