Skip to content

fix build failure on windows in android #47641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FouadMagdy01 wants to merge 3 commits into from
Closed

fix build failure on windows in android #47641

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f22f7b
fix build failure on windows in android
FouadMagdy01 Nov 15, 2024
5a5aead
revert changes
FouadMagdy01 Nov 17, 2024
d3e9f2f
fix build failure on windows in android and minimize changes
FouadMagdy01 Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/react-native/ReactAndroid/cmake-utils/ReactNative-application.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ endif(CCACHE_FOUND)

set(BUILD_DIR ${PROJECT_BUILD_DIR})
if(CMAKE_HOST_WIN32)
string(REPLACE "\\" "/" BUILD_DIR ${BUILD_DIR})
string(REPLACE "\\" "/" BUILD_DIR ${BUILD_DIR})
string(REPLACE "\\" "/" REACT_ANDROID_DIR ${REACT_ANDROID_DIR})
Comment on lines +35 to +36
Copy link
Contributor Author

@FouadMagdy01 FouadMagdy01 Nov 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Problem: The variables REACT_ANDROID_DIR and BUILD_DIR might also contain backslashes if they are set on a Windows system. These backslashes need to be replaced to avoid similar issues.

  • Solution: Check if the script is running on Windows using if(CMAKE_HOST_WIN32). If it is, replace backslashes with forward slashes for these variables as well:

endif()

if (PROJECT_ROOT_DIR)
Expand All @@ -44,6 +45,11 @@ file(GLOB input_SRC CONFIGURE_DEPENDS
${REACT_ANDROID_DIR}/cmake-utils/default-app-setup/*.cpp
${BUILD_DIR}/generated/autolinking/src/main/jni/*.cpp)

# Ensure that `input_SRC` paths use forward slashes
foreach(path IN LISTS input_SRC)
string(REPLACE "\\" "/" path "${path}")
endforeach()

Comment on lines +48 to +52
Copy link
Contributor Author

@FouadMagdy01 FouadMagdy01 Nov 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Problem: On Windows, backslashes () in file paths are often interpreted by CMake as escape characters, which can lead to invalid sequences like \S. CMake and many other tools can understand forward slashes (/) as directory separators, even on Windows.

  • Solution: Use string(REPLACE "\" "/" path "${path}") to convert all backslashes in the input_SRC file paths to forward slashes. This ensures CMake correctly interprets the paths without treating them as escape sequences.

add_library(${CMAKE_PROJECT_NAME} SHARED ${input_SRC})

target_include_directories(${CMAKE_PROJECT_NAME}
Expand Down
Loading