-
Notifications
You must be signed in to change notification settings - Fork 25.1k
feat: add overlayColor prop to modal component for customisable background overlay #46322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add overlayColor prop to modal component for customisable background overlay #46322
Conversation
|
@shubhamguptadream11 Thanks for submitting the PR. Let me try to review this next week. |
|
@alanleedev has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@shubhamguptadream11 Everything looks good but could you change the name |
|
@alanleedev Renamed the prop. Please check whenever you feel free. |
|
@alanleedev has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@alanleedev merged this pull request in 4e1d701. |
|
This pull request was successfully merged by @shubhamguptadream11 in 4e1d701 When will my fix make it into a release? | How to file a pick request? |
|
@shubhamguptadream11 hm... the merged commit did not have your name change for some reason. I'll do the name change again.
|
Summary: the name change [commit](facebook@64ee571) was not properly imported from last diff for facebook#46322 redoing the name change: overlayColor -> backdropColor Changelog: [general][Fixed] - rename overlayColor prop in Modal to backdropColor Differential Revision: D62760028
Summary: Pull Request resolved: #46523 the name change [commit](64ee571) was not properly imported from last diff for #46322 redoing the name change: overlayColor -> backdropColor Changelog: [general][Fixed] - rename overlayColor prop in Modal to backdropColor Reviewed By: christophpurrer Differential Revision: D62760028 fbshipit-source-id: 92d6e8f002c92f4e13136542dce946434516988e
Summary:
Solves these issues:
Solves this proposal: react-native-community/discussions-and-proposals#774
Changelog:
[GENERAL] [ADDED] - added overlayColor prop to modal component for customisable background overlay
Motivation:
Currently, the React Native Modal component only allows the background to be set to either
transparentorwhite. This limits the ability to dim the background or apply custom colors, which is essential for creating a more polished and user-friendly interface.Change Log:
Modal Component Enhancements:
overlayColorto the Modal component.overlayColorwhen transparent isfalse.whitewhenoverlayColoris not provided.Test Plan:
Sample screenshot with custom overlayColor passed as 'red'.