Fix duplicate rotation operations #44429
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57025602 |
Summary: `Transform::Rotation(x, y, z)` creates an empty transform with the associated operation, then [multiplies by xyz rotation vectors](https://en.wikipedia.org/wiki/Rotation_matrix#General_3D_rotations). Multiplication chains each transform operation, so afterward, we end up with correct transform matrix, but duplicate operations. This removes the first transform operation, and lets the per-axis multiplications set them. Changelog: [General][Fixed] - Fix duplicate rotation operations Differential Revision: D57025602
NickGerleman
force-pushed
the
export-D57025602
branch
from
664774e to
735e9b6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57025602 |
Base commit: 362abb9 |
Contributor
|
This pull request has been merged in 54f582f. |
|
This pull request was successfully merged by @NickGerleman in 54f582f. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44429 `Transform::Rotation(x, y, z)` creates an empty transform with the associated operation, then [multiplies by xyz rotation vectors](https://en.wikipedia.org/wiki/Rotation_matrix#General_3D_rotations). Multiplication chains each transform operation, so afterward, we end up with correct transform matrix, but duplicate operations. This removes the first transform operation, and lets the per-axis multiplications set them. Changelog: [General][Fixed] - Fix duplicate rotation operations Reviewed By: rshest Differential Revision: D57025602 fbshipit-source-id: 5eb47dbf9a72eab89a351fd5ae02261566b35ffb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Transform::Rotation(x, y, z)creates an empty transform with the associated operation, then multiplies by xyz rotation vectors.Multiplication chains each transform operation, so afterward, we end up with correct transform matrix, but duplicate operations.
This removes the first transform operation, and lets the per-axis multiplications set them.
Changelog:
[General][Fixed] - Fix duplicate rotation operations
Differential Revision: D57025602