[Android] Add isWideColorGamutEnabled to ReactActivityDelegate #43036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 7b00a92 |
This was referenced Feb 23, 2024
ryanlntn
force-pushed
the
feat/wide-gamut-color-activity
branch
from
76dbd8a to
45dc336
Compare
ryanlntn
force-pushed
the
feat/wide-gamut-color-activity
branch
from
45dc336 to
3009935
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Apr 23, 2024
Summary: This adds support for enabling wide color gamut mode for ReactActivity per the wide gamut color [RFC](react-native-community/discussions-and-proposals#738). ## Changelog: [ANDROID] [ADDED] - Add isWideColorGamutEnabled to ReactActivityDelegate Pull Request resolved: facebook#43036 Test Plan: Update RNTesterActivity.kt to enable wide color gamut: ```diff class RNTesterActivity : ReactActivity() { class RNTesterActivityDelegate(val activity: ReactActivity, mainComponentName: String) : // ... override fun getLaunchOptions() = if (this::initialProps.isInitialized) initialProps else Bundle() + override fun isWideColorGamutEnabled() = true } ``` Differential Revision: D55749124 Reviewed By: cortinico Pulled By: cortinico
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Apr 23, 2024
Summary: This adds support for enabling wide color gamut mode for ReactActivity per the wide gamut color [RFC](react-native-community/discussions-and-proposals#738). ## Changelog: [ANDROID] [ADDED] - Add isWideColorGamutEnabled to ReactActivityDelegate Pull Request resolved: facebook#43036 Test Plan: Update RNTesterActivity.kt to enable wide color gamut: ```diff class RNTesterActivity : ReactActivity() { class RNTesterActivityDelegate(val activity: ReactActivity, mainComponentName: String) : // ... override fun getLaunchOptions() = if (this::initialProps.isInitialized) initialProps else Bundle() + override fun isWideColorGamutEnabled() = true } ``` Differential Revision: D55749124 Reviewed By: cortinico Pulled By: cortinico
Contributor
|
@cipolleschi merged this pull request in 0a9891a. |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
May 6, 2024
Summary: This adds support for enabling wide color gamut mode for ReactActivity per the wide gamut color [RFC](react-native-community/discussions-and-proposals#738). ## Changelog: [ANDROID] [ADDED] - Add isWideColorGamutEnabled to ReactActivityDelegate Pull Request resolved: facebook#43036 Test Plan: Update RNTesterActivity.kt to enable wide color gamut: ```diff class RNTesterActivity : ReactActivity() { class RNTesterActivityDelegate(val activity: ReactActivity, mainComponentName: String) : // ... override fun getLaunchOptions() = if (this::initialProps.isInitialized) initialProps else Bundle() + override fun isWideColorGamutEnabled() = true } ``` Reviewed By: cortinico Differential Revision: D55749124 Pulled By: cipolleschi fbshipit-source-id: 44dd5631e1a2e429c86c01ed8747bbebbc8bdb3b
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: This adds support for enabling wide color gamut mode for ReactActivity per the wide gamut color [RFC](react-native-community/discussions-and-proposals#738). ## Changelog: [ANDROID] [ADDED] - Add isWideColorGamutEnabled to ReactActivityDelegate Pull Request resolved: facebook#43036 Test Plan: Update RNTesterActivity.kt to enable wide color gamut: ```diff class RNTesterActivity : ReactActivity() { class RNTesterActivityDelegate(val activity: ReactActivity, mainComponentName: String) : // ... override fun getLaunchOptions() = if (this::initialProps.isInitialized) initialProps else Bundle() + override fun isWideColorGamutEnabled() = true } ``` Reviewed By: cortinico Differential Revision: D55749124 Pulled By: cipolleschi fbshipit-source-id: 44dd5631e1a2e429c86c01ed8747bbebbc8bdb3b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This adds support for enabling wide color gamut mode for ReactActivity per the wide gamut color RFC.
Changelog:
[ANDROID] [ADDED] - Add isWideColorGamutEnabled to ReactActivityDelegate
Test Plan:
Update RNTesterActivity.kt to enable wide color gamut:
class RNTesterActivity : ReactActivity() { class RNTesterActivityDelegate(val activity: ReactActivity, mainComponentName: String) : // ... override fun getLaunchOptions() = if (this::initialProps.isInitialized) initialProps else Bundle() + override fun isWideColorGamutEnabled() = true }