fix(xcode): Pass hermesc $EXTRA_COMPILER_ARGS as individual arguments
#38199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If "$EXTRA_COMPILER_ARGS" is wrapped by `"` it will be passed to `hermesc` binary as one argument which will cause `Unknown command line argument` error when using `$SOURCEMAP_FILE` to generate Hermes source maps. ``` + EXTRA_COMPILER_ARGS='-O -output-source-map' + /Users/krystofwoldrich/repos/sentry-react-native/sample-new-architecture/ios/Pods/hermes-engine/destroot/bin/hermesc -emit-binary -max-diagnostic-width=80 '-O -output-source-map' -out /Users/krystofwoldrich/Library/Developer/Xcode/DerivedData/sampleNewArchitecture-dtnzzmpchfyuyyajisnbghavfleb/Build/Products/Release-iphonesimulator/sampleNewArchitecture.app/main.jsbundle /Users/krystofwoldrich/Library/Developer/Xcode/DerivedData/sampleNewArchitecture-dtnzzmpchfyuyyajisnbghavfleb/Build/Products/Release-iphonesimulator/main.jsbundle hermesc: Unknown command line argument '-O -output-source-map'. Try: '/Users/krystofwoldrich/repos/sentry-react-native/sample-new-architecture/ios/Pods/hermes-engine/destroot/bin/hermesc -help' ```
facebook-github-bot
added
CLA Signed
Base commit: 1489f0f |
cipolleschi
approved these changes
Jul 5, 2023
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
I will have to do something internally to make the linter happy. :(
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
Seems that this is the same as #38147 right? 😄 |
Contributor
|
Yes, Thanks @byCedric! |
Contributor
Author
|
@byCedric @cipolleschi Thanks, I've missed that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
If "$EXTRA_COMPILER_ARGS" is wrapped by
"it will be passed tohermescbinary as one argument which will causeUnknown command line argumenterror when using$SOURCEMAP_FILEto generate Hermes source maps.This error doesn't happen by default as the only argument in
$EXTRA_COMPILER_ARGSis-Obut if you add an extra argument or use$SOURCEMAP_FILEwhich results in multiple extra compiler args the error will happen.Introduced in a168f4b
Affects 0.72.0 and 0.72.1
Changelog:
[IOS] [FIXED] - Pass
hermesc$EXTRA_COMPILER_ARGS as individual argumentsTest Plan:
Run build with
$SOURCEMAP_FILEor any other$EXTRA_COMPILER_ARGSwhich has more than one argument.