trigger codegenned reflection if module is a turbomodule #36672
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D44445586 fbshipit-source-id: e5582ca489b47b46a21ee3168601df6a2af935c4
Differential Revision: D44450433 fbshipit-source-id: e4851de44c547a44a7023a61068d585835455188
Summary: Changelog: [Internal] if we look at usages of ReactModuleWithSpec, we see that it's existence was to simply identify generated native modules since the inheritance graph of native modules was different if they were generated. this was introduced before we created the TurboModule interface, which all codegenned native modules also conform to. since that exists now, there's no need for both of these. this is the only callsite in our code where ReactModuleWithSpec triggers any logic, so i'm updating it. Differential Revision: D44450687 fbshipit-source-id: 622007e0bceb9d4984bde561f6dec240872dd1b8
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44450687 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44450687 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Mar 28, 2023
) Summary: Pull Request resolved: facebook#36672 Changelog: [Internal] if we look at usages of ReactModuleWithSpec, we see that it's existence was to simply identify generated native modules since the inheritance graph of native modules was different if they were generated. this was introduced before we created the TurboModule interface, which all codegenned native modules also conform to. since that exists now, there's no need for both of these. this is the only callsite in our code where ReactModuleWithSpec triggers any logic, so i'm updating it. Differential Revision: D44450687 fbshipit-source-id: 799bac320851edfc09048446c9a5f947a126d9c7
Base commit: d9f7c4c |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Mar 28, 2023
) Summary: Pull Request resolved: facebook#36672 Changelog: [Internal] if we look at usages of ReactModuleWithSpec, we see that it's existence was to simply identify generated native modules since the inheritance graph of native modules was different if they were generated. this was introduced before we created the TurboModule interface, which all codegenned native modules also conform to. since that exists now, there's no need for both of these. this is the only callsite in our code where ReactModuleWithSpec triggers any logic, so i'm updating it. Differential Revision: D44450687 fbshipit-source-id: 97520424e4c781cf97aaaf1cfa55e2c1dc63761a
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44450687 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44450687 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Mar 28, 2023
) Summary: Pull Request resolved: facebook#36672 Changelog: [Internal] if we look at usages of ReactModuleWithSpec, we see that it's existence was to simply identify generated native modules since the inheritance graph of native modules was different if they were generated. this was introduced before we created the TurboModule interface, which all codegenned native modules also conform to. since that exists now, there's no need for both of these. this is the only callsite in our code where ReactModuleWithSpec triggers any logic, so i'm updating it. Reviewed By: javache Differential Revision: D44450687 fbshipit-source-id: c89840c4c94fba14afd80939b80dbab4672d74d1
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44450687 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Mar 29, 2023
) Summary: Pull Request resolved: facebook#36672 Changelog: [Internal] if we look at usages of ReactModuleWithSpec, we see that it's existence was to simply identify generated native modules since the inheritance graph of native modules was different if they were generated. this was introduced before we created the TurboModule interface, which all codegenned native modules also conform to. since that exists now, there's no need for both of these. this is the only callsite in our code where ReactModuleWithSpec triggers any logic, so i'm updating it. Reviewed By: javache Differential Revision: D44450687 fbshipit-source-id: 4ec83ffc71c78eb37387bd931f9226c4e35dca97
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Mar 29, 2023
) Summary: Pull Request resolved: facebook#36672 Changelog: [Internal] if we look at usages of ReactModuleWithSpec, we see that it's existence was to simply identify generated native modules since the inheritance graph of native modules was different if they were generated. this was introduced before we created the TurboModule interface, which all codegenned native modules also conform to. since that exists now, there's no need for both of these. this is the only callsite in our code where ReactModuleWithSpec triggers any logic, so i'm updating it. Reviewed By: javache Differential Revision: D44450687 fbshipit-source-id: 03af1cad1b1e7f89b008727137974d1ef57ceea2
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44450687 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44450687 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Mar 29, 2023
) Summary: Pull Request resolved: facebook#36672 Changelog: [Internal] if we look at usages of ReactModuleWithSpec, we see that it's existence was to simply identify generated native modules since the inheritance graph of native modules was different if they were generated. this was introduced before we created the TurboModule interface, which all codegenned native modules also conform to. since that exists now, there's no need for both of these. this is the only callsite in our code where ReactModuleWithSpec triggers any logic, so i'm updating it. Reviewed By: javache Differential Revision: D44450687 fbshipit-source-id: 3d7d4abdbf9979a9c6a37d7400ac7b52d94e6560
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44450687 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Mar 29, 2023
) Summary: Pull Request resolved: facebook#36672 Changelog: [Internal] if we look at usages of ReactModuleWithSpec, we see that it's existence was to simply identify generated native modules since the inheritance graph of native modules was different if they were generated. this was introduced before we created the TurboModule interface, which all codegenned native modules also conform to. since that exists now, there's no need for both of these. this is the only callsite in our code where ReactModuleWithSpec triggers any logic, so i'm updating it. Reviewed By: javache Differential Revision: D44450687 fbshipit-source-id: a84e04e1b8fc403545bfd689836995f9e61b8624
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Mar 29, 2023
) Summary: Pull Request resolved: facebook#36672 Changelog: [Internal] if we look at usages of ReactModuleWithSpec, we see that it's existence was to simply identify generated native modules since the inheritance graph of native modules was different if they were generated. this was introduced before we created the TurboModule interface, which all codegenned native modules also conform to. since that exists now, there's no need for both of these. this is the only callsite in our code where ReactModuleWithSpec triggers any logic, so i'm updating it. Reviewed By: javache Differential Revision: D44450687 fbshipit-source-id: be205d38ffab4ddabf617e133ca5fb82d0ee35bc
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44450687 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 29, 2023
Summary: Pull Request resolved: #36672 Changelog: [Internal] if we look at usages of ReactModuleWithSpec, we see that it's existence was to simply identify generated native modules since the inheritance graph of native modules was different if they were generated. this was introduced before we created the TurboModule interface, which all codegenned native modules also conform to. since that exists now, there's no need for both of these. this is the only callsite in our code where ReactModuleWithSpec triggers any logic, so i'm updating it. bypass-github-export-checks Reviewed By: javache Differential Revision: D44450687 fbshipit-source-id: f9c26fce8e360b6e319153aad83fc788079bac91
|
This pull request was successfully merged by @philIip in bd7aa2c. When will my fix make it into a release? | Upcoming Releases |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
) Summary: Pull Request resolved: facebook#36672 Changelog: [Internal] if we look at usages of ReactModuleWithSpec, we see that it's existence was to simply identify generated native modules since the inheritance graph of native modules was different if they were generated. this was introduced before we created the TurboModule interface, which all codegenned native modules also conform to. since that exists now, there's no need for both of these. this is the only callsite in our code where ReactModuleWithSpec triggers any logic, so i'm updating it. bypass-github-export-checks Reviewed By: javache Differential Revision: D44450687 fbshipit-source-id: f9c26fce8e360b6e319153aad83fc788079bac91
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
) Summary: Pull Request resolved: facebook#36672 Changelog: [Internal] if we look at usages of ReactModuleWithSpec, we see that it's existence was to simply identify generated native modules since the inheritance graph of native modules was different if they were generated. this was introduced before we created the TurboModule interface, which all codegenned native modules also conform to. since that exists now, there's no need for both of these. this is the only callsite in our code where ReactModuleWithSpec triggers any logic, so i'm updating it. bypass-github-export-checks Reviewed By: javache Differential Revision: D44450687 fbshipit-source-id: f9c26fce8e360b6e319153aad83fc788079bac91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
if we look at usages of ReactModuleWithSpec, we see that it's existence was to simply identify generated native modules since the inheritance graph of native modules was different if they were generated.
this was introduced before we created the TurboModule interface, which all codegenned native modules also conform to. since that exists now, there's no need for both of these. this is the only callsite in our code where ReactModuleWithSpec triggers any logic, so i'm updating it.
Differential Revision: D44450687