Import template/android/ as part of the top level build #32124
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: facebook#32073 This Diff bumps the version of Gradle used to build the project to 7.0.2. Ideally we could bump to 7.2.x directly, but I'll do one minor version at a time to exclude potential build problems. This diff is addressing all the extra build warnings that got raised by the new version. Changelog: [Android][Changed] - Bumped Gradle project version to 7.0.2 Reviewed By: ShikaSD Differential Revision: D30486612 fbshipit-source-id: 97a705414e8fbee685f80219027d2593499d333e
Summary: This Diff adds `template/android/` as part of the top level build as an included build. This means that the Android template will be loaded inside Android studio and it will be easier to invoke tasks directly there. I'm also bumping Gradle to 7.0.2 for the template. Please note that the template relies on the `template/node_modules` folder to work correctly, as the Gradle build is loading a file from there. Therefore I've added a check to verify that we import the build only if `node_modules` is available. Changelog: [Internal] [Changed] - Load template/android/ inside the build. Differential Revision: D30672845 fbshipit-source-id: d69b7fbda66ee225894dd70fd1dcb106db63f46e
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D30672845 |
|
Base commit: 2e8893f |
Base commit: 2e8893f |
Contributor
|
This pull request has been merged in 13107fa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This Diff adds
template/android/as part of the top level build as an includedbuild. This means that the Android template will be loaded inside Android studio and it
will be easier to invoke tasks directly there.
I'm also bumping Gradle to 7.0.2 for the template.
Please note that the template relies on the
template/node_modulesfolder towork correctly, as the Gradle build is loading a file from there.
Therefore I've added a check to verify that we import the build only if
node_modulesis available.
Changelog:
[Internal] [Changed] - Load template/android/ inside the build.
Differential Revision: D30672845