Skip to content

Conversation

@sasurau4
Copy link
Contributor

Summary

In monorepo environment, prettier-plugin in some editor load from nearest node_modules. Older version of eslint-config-react-native-community includes prettier v1 in their dependencies. It cause conflict of code style inside the monorepo.

Changelog

[Internal] [Fixed] - move prettier to peerDependencies in eslint-config-react-native-community

Test Plan

I think it would be good with no plan to test.

@sasurau4 sasurau4 requested a review from matt-oakes as a code owner April 15, 2020 14:34
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2020
@analysis-bot
Copy link

analysis-bot commented Apr 15, 2020

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,964,406 -284,457
android hermes armeabi-v7a 8,496,410 -271,382
android hermes x86 9,390,439 -301,027
android hermes x86_64 9,357,807 -301,384
android jsc arm64-v8a 10,628,420 -255,898
android jsc armeabi-v7a 9,549,613 -244,901
android jsc x86 10,641,480 -280,845
android jsc x86_64 11,252,563 -278,998

Base commit: f3e8ea9

@analysis-bot
Copy link

analysis-bot commented Apr 15, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: f3e8ea9

Copy link
Contributor

@matt-oakes matt-oakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. Does anyone know how this would affect users and if it’s a breaking change at all?

@sasurau4 sasurau4 force-pushed the move-prettier-to-peer-deps branch from 5da5fff to a1cc032 Compare July 16, 2020 01:23
@sasurau4
Copy link
Contributor Author

I want to review it. Anyone knows I should mention whom?

@matt-oakes
Copy link
Contributor

@cpojer Do you know who would be the best person to look into this?

@charlesbdudley charlesbdudley self-assigned this Aug 27, 2021
@charlesbdudley
Copy link
Contributor

Hi @sasurau4, do you mind rebasing and fixing conflicts and we'll take another look, thanks!

@sasurau4 sasurau4 force-pushed the move-prettier-to-peer-deps branch from a1cc032 to cc2ad44 Compare August 28, 2021 11:19
@sasurau4
Copy link
Contributor Author

@charlesbdudley rebased, thanks for your comment 👍

@facebook-github-bot
Copy link
Contributor

@charlesbdudley has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@charlesbdudley merged this pull request in de1a72a.

@matt-oakes
Copy link
Contributor

@charlesbdudley Thanks for merging this. Can you also take a look at and merge #32117 so I can release these changes to NPM?

facebook-github-bot pushed a commit that referenced this pull request Aug 31, 2021
Summary:
The version of this package needs to be bumped for me to release the changes from #28637 to NPM.

## Changelog

[Internal] [Added] - Bump react-native-community/eslint-config version

Pull Request resolved: #32117

Test Plan: N/A

Reviewed By: cortinico

Differential Revision: D30663708

Pulled By: yungsters

fbshipit-source-id: f433c324f12663d76e55c9395630cd642955b25e
@matt-oakes
Copy link
Contributor

Published to NPM as 3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants