-
Notifications
You must be signed in to change notification settings - Fork 25k
move prettier to peerDeps in eslint-config-react-native-community #28637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Base commit: f3e8ea9 |
Base commit: f3e8ea9 |
matt-oakes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense. Does anyone know how this would affect users and if it’s a breaking change at all?
5da5fff to
a1cc032
Compare
|
I want to review it. Anyone knows I should mention whom? |
|
@cpojer Do you know who would be the best person to look into this? |
|
Hi @sasurau4, do you mind rebasing and fixing conflicts and we'll take another look, thanks! |
a1cc032 to
cc2ad44
Compare
|
@charlesbdudley rebased, thanks for your comment 👍 |
|
@charlesbdudley has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@charlesbdudley merged this pull request in de1a72a. |
|
@charlesbdudley Thanks for merging this. Can you also take a look at and merge #32117 so I can release these changes to NPM? |
Summary: The version of this package needs to be bumped for me to release the changes from #28637 to NPM. ## Changelog [Internal] [Added] - Bump react-native-community/eslint-config version Pull Request resolved: #32117 Test Plan: N/A Reviewed By: cortinico Differential Revision: D30663708 Pulled By: yungsters fbshipit-source-id: f433c324f12663d76e55c9395630cd642955b25e
|
Published to NPM as |
Summary
In monorepo environment, prettier-plugin in some editor load from nearest
node_modules. Older version of eslint-config-react-native-community includes prettier v1 in their dependencies. It cause conflict of code style inside the monorepo.Changelog
[Internal] [Fixed] - move prettier to peerDependencies in eslint-config-react-native-community
Test Plan
I think it would be good with no plan to test.