JSBigString.h: Remove duplicate include of 'unistd.h' #23297
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
facebook-github-bot
approved these changes
Feb 5, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@empyrical merged commit cae6bef into |
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: This removes the accidental double include of the header `unistd.h` from `JSBigString.h`. One was added by me as part of facebook#22330, and one by matthargett as part of facebook#21764 [General] [Fixed] - `JSBigString.h`: Removed accidental double include of header `unistd.h` Pull Request resolved: facebook#23297 Differential Revision: D13961223 Pulled By: hramos fbshipit-source-id: c0dba8a475b3c09356d34cb65b989c286793fa67
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes the accidental double include of the header
unistd.hfromJSBigString.h. One was added by me as part of #22330, and one by @matthargett as part of #21764Changelog
[General] [Fixed] -
JSBigString.h: Removed accidental double include of headerunistd.hTest Plan
No compile regressions were noted.