-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Extract CLI out #22174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract CLI out #22174
Changes from 2 commits
b84afe6
bf36177
ecb6d98
47e0658
586f54f
5373544
af5e7cf
c200278
83ae4ba
2287be4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assetPathUtils are not limited to images. They also impact all other types of assets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but my understanding is that the "impact" is more present in the
local-clicontext where the utils are used to generate a path to any type of asset.On the React Native side of things, this file is only used in
Imagemodule. Anyway, this shouldn't be an issue now that thelocal-clifolder will not be removed. I am going to revert this change and w can leave this to be refactored at some point.