Add tests for out-of-tree platform support

[empyrical]

This PR adds tests for out-of-tree platform support.

A new test has been added to hasteImpl-test.js which both verifies the ability of findPlugins to find out of tree platforms, and the ability of hasteImpl to add relevant whitelists and name reducers for out of tree platforms.

Test Plan:

A test has been added to hasteImpl.js's test, so you can try it out by running yarn test. I've added an e2e test for running the bundler on this "dummy" platform.

Release Notes:

[CLI] [ENHANCEMENT] [jest/hasteImpl.js] The hasteImpl is now aware of whether it's in React Native CI, and will change where it looks for "plugins" accordingly
[CLI] [ENHANCEMENT] [jest/tests/hasteImpl-test.js] hasteImpl.js' plugin support is tested
[INTERNAL] [ENHANCEMENT] [ContainerShip/scripts/run-ci-e2e-tests.sh] Bundling the "dummy" platform is now part of the E2E test
[INTERNAL] [ENHANCEMENT] [package.json] The "dummy" platform has been added as a devDependency

[pull-bot]

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️	📋 Release Notes - This PR may have incorrectly formatted Release Notes.

Generated by 🚫 dangerJS

[empyrical]

Yep, still the same issue: (test_objc)

error: bundling failed: Error: jest-haste-map: @providesModule naming collision:
  Duplicate module name: react-native-dummy
  Paths: /Users/distiller/react-native/RNTester/js/OutOfTreeTestPlatform/package.json collides with /Users/distiller/react-native/node_modules/react-native-dummy/package.json

This error is caused by a @providesModule declaration with the same name across two different files.
    at setModule (/Users/distiller/react-native/node_modules/jest-haste-map/build/index.js:462:17)
    at workerReply (/Users/distiller/react-native/node_modules/jest-haste-map/build/index.js:512:9)
    at process._tickCallback (internal/process/next_tick.js:68:7)
::1 - - [31/Aug/2018:02:11:31 +0000] "GET /IntegrationTests/IntegrationTestsApp.bundle?platform=ios&dev=true HTTP/1.1" 200 - "-" "RNTester/1 CFNetwork/901.1 Darwin/17.4.0"
error: bundling failed: Error: jest-haste-map: @providesModule naming collision:
  Duplicate module name: react-native-dummy
  Paths: /Users/distiller/react-native/RNTester/js/OutOfTreeTestPlatform/package.json collides with /Users/distiller/react-native/node_modules/react-native-dummy/package.json

This error is caused by a @providesModule declaration with the same name across two different files.
    at setModule (/Users/distiller/react-native/node_modules/jest-haste-map/build/index.js:462:17)
    at workerReply (/Users/distiller/react-native/node_modules/jest-haste-map/build/index.js:512:9)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Will have to come up with a way to fix this.

[empyrical]

The dummy platform has been moved to its own module/repo, and tests look much better now!

https://github.com/react-native-community/react-native-dummy
https://www.npmjs.com/package/react-native-dummy

[matthargett]

test_android failure is unrelated. again.

No build file at ReactAndroid/src/main/java/com/facebook/thecount/BUCK when resolving target //ReactAndroid/src/main/java/com/facebook/thecount:thecount.

This error happened while trying to get dependency '//ReactAndroid/src/main/java/com/facebook/thecount:thecount' of target '//ReactAndroid/src/main/java/com/facebook/react/bridge:bridge'

[empyrical]

Rebased against master and things look better 👌

[facebook-github-bot]

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[empyrical]

Not sure what it got caught on

[hramos]

Re-trying.

[hramos]

@empyrical the internal diff is failing JavaScript tests:

 FAIL  jest/__tests__/hasteImpl-test.js
  ✕ returns the correct haste name for a file with an out-of-tree platform suffix (34ms)
  ○ skipped 6 tests

  ● returns the correct haste name for a file with an out-of-tree platform suffix

    expect(received).toEqual(expected)

    Expected value to equal:
      "AccessibilityInfo"
    Received:
      "AccessibilityInfo.dummy"

      58 |         ),
      59 |       ),
    > 60 |     ).toEqual('AccessibilityInfo');
         |     ^
      61 |   }
      62 | });
      63 |

      at Object.<anonymous> (jest/__tests__/hasteImpl-test.js:60:5)

Test Suites: 1 failed, 1 total
Tests:       1 failed, 6 skipped, 7 total
Snapshots:   0 total
Time:        0.518s, estimated 1s
Ran all test suites related to changed files.

[empyrical]

Very weird that it is working in OSS but not internally. Since react-native-dummy is a new dependency, do you have internal checks/approvals that need to be done to allow new dependencies through?

[empyrical]

Or -- would adding the changed yarn.lock to this PR help?

[hramos]

I did have to take care of that internally, since we have an offline yarn mirror.

Let me re-import, as the internal diff might be out of date.

[facebook-github-bot]

hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[hramos]

I am still working on this. Will update soon.

[hramos]

I'm at a loss. Jest is still failing the new test case when run internally:

 ● returns the correct haste name for a file with an out-of-tree platform suffix

    expect(received).toEqual(expected)

    Expected value to equal:
      "AccessibilityInfo"
    Received:
      "AccessibilityInfo.dummy"

      58 |         ),
      59 |       ),
    > 60 |     ).toEqual('AccessibilityInfo');
         |     ^
      61 |   }
      62 | });
      63 | 

      at Object.<anonymous> (jest/__tests__/hasteImpl-test.js:60:5)

[empyrical]

So, the reason that test would fail is because findPlugins isn't able to see the react-native-dummy platform for some reason.

react-native/jest/hasteImpl.js

Lines 16 to 26 in f5dd2c4

	const REACT_NATIVE_CI = process.cwd() === path.resolve(__dirname, '..');
	let pluginsPath;
	if (REACT_NATIVE_CI) {
	pluginsPath = '..';
	} else {
	pluginsPath = '../../../';
	}
	const plugins = findPlugins([path.resolve(__dirname, pluginsPath)]);

In hasteImpl, I've set it to look in ../node_modules if it detects that it is being ran as part of React Native's tests, rather than ../../../node_modules where it's inside of a react native project. It does this detection by checking if the cwd() is the parent directory. It is possible that cwd() may be different somehow for the internal tests.

If you were to have a console.log or something there to print the value of the REACT_NATIVE_CI variable, does it show up as true or false? If it's false that may be the issue and I'd have to come up with a different way to detect if it's in CI.

[hramos]

A-ha! We're using Yarn Plug-n-Play, so node_modules is not a thing in the environment these tests are running in.

I'm aware of an alternate way to detect if a test is running within our internal CI. I am not sure if it's something that would be OK to include in open source, but regardless, it looks like we'd need to solve not having node_modules available in the internal CI.

[empyrical]

The way that findPlugins currently works is it doesn't use require.resolve or anything like that - it concats the input directory + node_modules + {module_name} + package.json.

react-native/local-cli/core/findPlugins.js

Lines 104 to 111 in 4b106be

	if (isReactNativePlugin(pkg)) {
	const pkgJson = readPackage(path.join(folder, 'node_modules', pkg));
	if (pkgJson) {
	commands = commands.concat(findPluginsInReactNativePackage(pkgJson));
	platforms = platforms.concat(findPlatformsInPackage(pkgJson));
	findHasteConfigInPackageAndConcat(pkgJson, haste);
	}
	}

It looks like RNPM will need to be adapted to work with Yarn Plug 'n Play. For now, perhaps this test could somehow be skipped on the internal test suite until YPNP is made public?

[empyrical]

Actually - perhaps I could modify the test to skip itself if the node_modules folder isn't detected.

[empyrical]

@hramos I modified the hasteImpl test to skip if node_modules/react-native-dummy isn't present. Will this pass in the internal test suite?

[hramos]

Sorry for the delay. I just incorporated your updates into the internal diff. Will merge if tests pass. Thanks!

[react-native-bot]

@empyrical merged commit 57041ee into facebook:master.

---

Once this commit is added to a release, you will see the corresponding version tag below the description at 57041ee. If the commit has a single master tag, it is not yet part of a release.