Skip to content

[Bugfix] Fixing Unhandled promise rejection on iOS WebView #20918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Bugfix] Fixing Unhandled promise rejection on iOS WebView #20918

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24b9b2d
Fixing Unhandled promise rejection on iOS WebView
Aug 30, 2018
1bd6b67
Fix linting
UrbanChrisy Aug 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Libraries/Components/WebView/WebView.ios.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,13 @@ class WebView extends React.Component {
);
shouldStart = shouldStart && passesWhitelist;
if (!passesWhitelist) {
Linking.openURL(url);
Linking.openURL(url)
.then(() => {
//ignored
})
.catch(() => {
//ignored
Copy link
Contributor

@hramos hramos Aug 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we at least YellowBox in dev in this case?

Copy link
Author

@UrbanChrisy UrbanChrisy Sep 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that could be handy. How do would you like the yellow box shown here?

});
}
if (this.props.onShouldStartLoadWithRequest) {
shouldStart =
Expand Down