Skip to content

fix codegenNativeCommands section example #3024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cortinico merged 2 commits into from
Mar 21, 2022
Merged

fix codegenNativeCommands section example #3024

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7251444
fix codegenNativeCommands part
troZee Mar 21, 2022
8695813
fix lint
Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions docs/new-architecture-library-intro.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,20 +445,18 @@ class MyComponent extends React.Component<Props> {
**Creating the NativeCommands with `codegenNativeCommands`**

```ts title="MyCustomMapNativeComponent.js"
import codegeNativeCommands from 'react-native/Libraries/Utilities/codegenNativeCommands';
...
type Props = {...};
import codegenNativeCommands from 'react-native/Libraries/Utilities/codegenNativeCommands';
import type { HostComponent } from 'react-native/Libraries/Renderer/shims/ReactNativeTypes';

const MyCustomMapNativeComponent: HostComponent<Props> =
requireNativeComponent<Props>('MyCustomMapNativeComponent');
type MyCustomMapNativeComponentType = HostComponent<NativeProps>;

interface NativeCommands {
moveToRegion: (
ref: React.ElementRef<typeof MyCustomMapNativeComponent>,
region: MapRegion,
duration: number,
) => void;
}
+moveToRegion: (
viewRef: React.ElementRef<MyCustomMapNativeComponentType>,
region: MapRegion,
duration: number,
) => void;
}

export const Commands: NativeCommands = codegenNativeCommands<NativeCommands>({
supportedCommands: ['moveToRegion'],
Expand Down