Skip to content

Conversation

@lunaleaps
Copy link
Contributor

@lunaleaps lunaleaps commented Dec 21, 2021

Working on:

  • Editing the opening sections to explain "what this doc will tell you and why you might care" a little better (re: adding context that these docs are discussing about the new architecture Fabric and link to the "Fabric Page")
  • Split up "rendering-implementation" into 3 sections
  • Added a 1-line summary of each doc

@lunaleaps lunaleaps changed the title Lunaleaps fabric architecture Iterating on Fabric Architecture docs Dec 21, 2021
@lunaleaps lunaleaps force-pushed the lunaleaps-fabric-architecture branch from ea170b9 to f0d0d3b Compare December 21, 2021 23:19
@lunaleaps lunaleaps changed the base branch from fabric-architecture to main December 22, 2021 00:40
@lunaleaps lunaleaps closed this Dec 22, 2021
@lunaleaps lunaleaps reopened this Dec 22, 2021
@lunaleaps
Copy link
Contributor Author

Hmm I'm wondering how to trigger netlify on this, I might close and re-open this PR?

@Simek
Copy link
Collaborator

Simek commented Dec 22, 2021

Hmm I'm wondering how to trigger netlify on this, I might close and re-open this PR?

Currently deploy preview is setup only to work on the PRs targeting main branch. I cannot recall why this was setup in that way.

Same problem affects #2882, so maybe we should update the preview deploy workflow?

@lunaleaps lunaleaps changed the base branch from main to fabric-architecture December 22, 2021 18:02
@lunaleaps lunaleaps merged commit 00d33df into facebook:fabric-architecture Dec 22, 2021
@lunaleaps lunaleaps deleted the lunaleaps-fabric-architecture branch December 22, 2021 18:51
lunaleaps pushed a commit that referenced this pull request Dec 22, 2021
* Add some intro to 'Render,Commit, and Mount'

* Update Fabric Render -> Fabric Renderer

* Split out rendering-implementation into three different docs

* Create a sentence callout for each
sammy-SC added a commit that referenced this pull request Dec 23, 2021
#2892)

* Initial draft of new Architecture Section including docs on how React Native's renderer works

* linting language

* changing the IA for architecture section

* update arc overview

* Iterating on Fabric Architecture docs (#2895)

* Add some intro to 'Render,Commit, and Mount'

* Update Fabric Render -> Fabric Renderer

* Split out rendering-implementation into three different docs

* Create a sentence callout for each

* Fix broken links

* Formatting for view-flattening (#2899)

* Updates to xplat-implementation, re: glossary links and fabric terms (#2898)

* Refactor how we layout the scenarios (#2897)

* Format render-pipeline.md (#2900)

* Format fabric-renderer.md (#2901)

* Format fabric-renderer.md

* Anchor fabric-renderer in time

* Add images to Fabric Deep Dive (#2902)

* Resize images in threading model section (#2903)

* Fabric-rendering word tweaks

* Cut a 0.66 version of the architecture and update header

* Word tweaks

Co-authored-by: Luna <[email protected]>
Co-authored-by: Samuel Susla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants