-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add linting for insensitive and inconsiderate language #1337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
56c788d
801d025
401accd
4682e6e
debb852
a2663b1
f01dfac
b083f34
1cda08e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| # The Code of Conduct calls out language that can't be used so it's not linted. | ||
| CODE_OF_CONDUCT.md | ||
|
|
||
| # We will handle the blog posts after the main docs are linted. | ||
| website/blog/ | ||
|
|
||
| # The version docs are actively being linted. | ||
| # If you want to lint one of these directories, remove it from the list here and then run: | ||
| # `yarn lintv website/versioned_docs/version-{version number}/` | ||
| # Once you fix all of the errors, commit all of the changes including this file. | ||
| # | ||
| # To be considerate to the reviewer, please submit each version in different PRs. | ||
| website/versioned_docs/version-0.5/ | ||
| website/versioned_docs/version-0.6/ | ||
| website/versioned_docs/version-0.7/ | ||
| website/versioned_docs/version-0.8/ | ||
| website/versioned_docs/version-0.9/ | ||
| website/versioned_docs/version-0.10/ | ||
| website/versioned_docs/version-0.11/ | ||
| website/versioned_docs/version-0.12/ | ||
| website/versioned_docs/version-0.13/ | ||
| website/versioned_docs/version-0.14/ | ||
| website/versioned_docs/version-0.15/ | ||
| website/versioned_docs/version-0.16/ | ||
| website/versioned_docs/version-0.17/ | ||
| website/versioned_docs/version-0.18/ | ||
| website/versioned_docs/version-0.19/ | ||
| website/versioned_docs/version-0.20/ | ||
| website/versioned_docs/version-0.21/ | ||
| website/versioned_docs/version-0.22/ | ||
| website/versioned_docs/version-0.23/ | ||
| website/versioned_docs/version-0.24/ | ||
| website/versioned_docs/version-0.25/ | ||
| website/versioned_docs/version-0.26/ | ||
| website/versioned_docs/version-0.27/ | ||
| website/versioned_docs/version-0.28/ | ||
| website/versioned_docs/version-0.29/ | ||
| website/versioned_docs/version-0.30/ | ||
| website/versioned_docs/version-0.31/ | ||
| website/versioned_docs/version-0.32/ | ||
| website/versioned_docs/version-0.33/ | ||
| website/versioned_docs/version-0.34/ | ||
| website/versioned_docs/version-0.35/ | ||
| website/versioned_docs/version-0.36/ | ||
| website/versioned_docs/version-0.37/ | ||
| website/versioned_docs/version-0.38/ | ||
| website/versioned_docs/version-0.39/ | ||
| website/versioned_docs/version-0.40/ | ||
| website/versioned_docs/version-0.41/ | ||
| website/versioned_docs/version-0.42/ | ||
| website/versioned_docs/version-0.43/ | ||
| website/versioned_docs/version-0.44/ | ||
| website/versioned_docs/version-0.45/ | ||
| website/versioned_docs/version-0.46/ | ||
| website/versioned_docs/version-0.47/ | ||
| website/versioned_docs/version-0.48/ | ||
| website/versioned_docs/version-0.49/ | ||
| website/versioned_docs/version-0.50/ | ||
| website/versioned_docs/version-0.51/ | ||
| website/versioned_docs/version-0.52/ | ||
| website/versioned_docs/version-0.53/ | ||
| website/versioned_docs/version-0.54/ | ||
| website/versioned_docs/version-0.55/ | ||
| website/versioned_docs/version-0.56/ | ||
| website/versioned_docs/version-0.57/ | ||
| website/versioned_docs/version-0.58/ | ||
| website/versioned_docs/version-0.59/ | ||
| website/versioned_docs/version-0.60/ | ||
| website/versioned_docs/version-0.61/ |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| /** | ||
| * Copyright (c) Facebook, Inc. and its affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| exports.allow = [ | ||
| // We frequently refer to form props by their name "disabled". | ||
| // Ideally we would alex-ignore only the valid uses (PRs accepted). | ||
| "invalid", | ||
|
|
||
| // Unfortunately "watchman" is a library name that we depend on. | ||
| "watchman-watchwoman" | ||
| ]; | ||
|
|
||
| // Use a "maybe" level of profanity instead of the default "unlikely". | ||
| exports.profanitySureness = 1; | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When this is set to 0 it is too eager, it catches words like "color", "execute", and "fire" which in our context are super unlikely to be profane and highly likely to be valid
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should you put your reasoning as a comment in the code? |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are just two rules that we're opting out of