Try to fix ParamSpec test for windows. #2121
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Up until 3.10 typing_extensions defined ParamSpec locally. Starting in 3.10 and greater typing extensions instead re-exports ParamSpec from typing.
I believe this may have been the issue causing this test to fail. All the flaky tests we have seen on Windows have been features that have been gated by specific versions.
In order to account for this, we can always trying getting ParamSpec from typing_extensions since it will always be available there.
Reviewed By: kinto0
Differential Revision: D90777432