[lsp] consider Options.all for typeCoverage command #8522
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mroch would this be something that could be potentially merged? I have read the original commit (d0b46ea), but I think it should not be necessary to include With |
LSP did only check coverage for pragma files and simply ignoring the all option. I did mimic the functionality from `flow coverage` command.
There was a problem hiding this comment.
@mroch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 12, 2020
Summary: Enables type coverage trough LSP in non pragma workspaces with `all=true` option. Previously the files were ignored and type coverage was only working on pragma files. flow/flow-for-vscode#138 (comment) <!-- If this is a change to library defintions, please include links to relevant documentation. If this is a documentation change, please prefix the title with [DOCS]. If this is neither, ensure you opened a discussion issue and link it in the PR description. --> Pull Request resolved: #8522 Reviewed By: nmote Differential Revision: D24890501 (aa33df7) Pulled By: mroch fbshipit-source-id: a1bb7bf136a660c3838a60e96455a23480d571cf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables type coverage trough LSP in non pragma workspaces with
all=trueoption. Previously the files were ignored and type coverage was only working on pragma files.flow/flow-for-vscode#138 (comment)