Skip to content

[Accton][minipack3bta] Re-enable SET_TC ACL action for TomahawkUltra1#1362

Open
jeankuo wants to merge 1 commit into
facebook:mainfrom
jeankuo:dev-tu1-enable-set-tc
Open

[Accton][minipack3bta] Re-enable SET_TC ACL action for TomahawkUltra1#1362
jeankuo wants to merge 1 commit into
facebook:mainfrom
jeankuo:dev-tu1-enable-set-tc

Conversation

@jeankuo

@jeankuo jeankuo commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR.
  • pre-commit run

Summary

Earlier Broadcom SAI did not support SAI_ACL_ENTRY_ATTR_ACTION_SET_TC on TU1 (BCM78920). A guard was added in genAclActionTypesConfig() to remove SET_TC from the supported action types list for this ASIC.

The current SAI version now supports this action. Remove the TU1-specific guard so SET_TC is included in the ingress ACL table action types.

Test Plan:

  • Verified ACL table creation with SET_TC action passes on minipack3bta (BCM78920 TU1 A0).
  • Confirmed SET_TC entries can be programmed in ingress ACL without error.
  • Platform: BCM78920 (Tomahawk Ultra 1) A0

@jeankuo jeankuo requested a review from a team as a code owner July 6, 2026 05:59
@meta-cla meta-cla Bot added the CLA Signed label Jul 6, 2026
@github-actions github-actions Bot added the accton label Jul 6, 2026
@jeankuo jeankuo force-pushed the dev-tu1-enable-set-tc branch from 90cfb3a to c0dc424 Compare July 6, 2026 06:09
Earlier Broadcom SAI did not support SAI_ACL_ENTRY_ATTR_ACTION_SET_TC on
TU1 (BCM78920). A guard was added in genAclActionTypesConfig() to remove
SET_TC from the supported action types list for this ASIC.

The current SAI version now supports this action. Remove the TU1-specific
guard so SET_TC is included in the ingress ACL table action types.
@jeankuo jeankuo force-pushed the dev-tu1-enable-set-tc branch from c0dc424 to 8441318 Compare July 7, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant