Add integrated_transceiver_mapping.py to OSS platform mapping gen sources#1360
Closed
KevinYakar wants to merge 1 commit into
Closed
Add integrated_transceiver_mapping.py to OSS platform mapping gen sources#1360KevinYakar wants to merge 1 commit into
KevinYakar wants to merge 1 commit into
Conversation
…rces Summary: The OSS build enumerates the `platform_mapping_v2` Python sources by hand in cmake (unlike the internal Buck build, which globs `srcs`). D107602208 added `fboss/lib/platform_mapping_v2/integrated_transceiver_mapping.py` and imported it from `platform_mapping_v2.py`, but did not add it to these lists. As a result the OSS-packaged `platform_mapping_gen_unit_test`, `platform_mapping_gen_no_regression_test`, and the `fboss-platform-mapping-gen` binary were missing the module and failed at import with `ModuleNotFoundError: No module named 'fboss.lib.platform_mapping_v2.integrated_transceiver_mapping'`. Internal CI stayed green because Buck globs the sources. Add the module to all three `PLATFORM_MAPPING_PY_SRCS` lists. Differential Revision: D110524523
Contributor
|
@KevinYakar has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110524523. |
Contributor
|
This pull request has been merged in c8ec7e4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The OSS build enumerates the
platform_mapping_v2Python sources by hand in cmake (unlike the internal Buck build, which globssrcs). D107602208 addedfboss/lib/platform_mapping_v2/integrated_transceiver_mapping.pyand imported it fromplatform_mapping_v2.py, but did not add it to these lists. As a result the OSS-packagedplatform_mapping_gen_unit_test,platform_mapping_gen_no_regression_test, and thefboss-platform-mapping-genbinary were missing the module and failed at import withModuleNotFoundError: No module named 'fboss.lib.platform_mapping_v2.integrated_transceiver_mapping'. Internal CI stayed green because Buck globs the sources.Add the module to all three
PLATFORM_MAPPING_PY_SRCSlists.Differential Revision: D110524523