This repository was archived by the owner on Feb 6, 2023. It is now read-only.
Bring back the ariaOwneeID prop. #1883
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This looks good to me! @jessebeach, can you confirm since you're more familiar with this area? :) |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
niveditc has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
cdelahousse has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
cdelahousse has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Sorry for the noise. Just testing some stuff on our end with GitHub integration. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
cdelahousse has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
cdelahousse has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: **Summary** Reverts facebookarchive@7f0cab2 to bring back the `ariaOwneeID` prop. The ARIA property `aria-owns` is required for the combobox ARIA widget, in both ARIA 1.0 and 1.1. Some plugins, for example the Mentions and Emoji plugins, still pass an `ariaOwneeID` prop which at the moment doesn't do anything. Also, without `aria-owns`, some browser / screen reader combinations don't read out the suggestions at all. For more details please refer to the related issue facebookarchive#1736. Fixes facebookarchive#1736. Pull Request resolved: facebookarchive#1883 Reviewed By: vdurmont Differential Revision: D10371390 Pulled By: vdurmont fbshipit-source-id: 140282124128437e0d8cc9b08490420c3dc81dc1
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Reverts facebookarchive/draft-js@7f0cab2 to bring back the `ariaOwneeID` prop. The ARIA property `aria-owns` is required for the combobox ARIA widget, in both ARIA 1.0 and 1.1. Some plugins, for example the Mentions and Emoji plugins, still pass an `ariaOwneeID` prop which at the moment doesn't do anything. Also, without `aria-owns`, some browser / screen reader combinations don't read out the suggestions at all. For more details please refer to the related issue #1736. Fixes #1736. Pull Request resolved: facebookarchive/draft-js#1883 Reviewed By: vdurmont Differential Revision: D10371390 Pulled By: vdurmont fbshipit-source-id: 140282124128437e0d8cc9b08490420c3dc81dc1
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** Reverts facebookarchive/draft-js@6982838 to bring back the `ariaOwneeID` prop. The ARIA property `aria-owns` is required for the combobox ARIA widget, in both ARIA 1.0 and 1.1. Some plugins, for example the Mentions and Emoji plugins, still pass an `ariaOwneeID` prop which at the moment doesn't do anything. Also, without `aria-owns`, some browser / screen reader combinations don't read out the suggestions at all. For more details please refer to the related issue #1736. Fixes #1736. Pull Request resolved: facebookarchive/draft-js#1883 Reviewed By: vdurmont Differential Revision: D10371390 Pulled By: vdurmont fbshipit-source-id: 140282124128437e0d8cc9b08490420c3dc81dc1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reverts 7f0cab2 to bring back the
ariaOwneeIDprop. The ARIA propertyaria-ownsis required for the combobox ARIA widget, in both ARIA 1.0 and 1.1. Some plugins, for example the Mentions and Emoji plugins, still pass anariaOwneeIDprop which at the moment doesn't do anything. Also, withoutaria-owns, some browser / screen reader combinations don't read out the suggestions at all. For more details please refer to the related issue #1736.Fixes #1736.