Skip to content

Commit 2115ff7

Browse files
aferciajdecked
authored andcommitted
Bring back the ariaOwneeID prop. (facebookarchive#1883)
Summary: **Summary** Reverts facebookarchive@7f0cab2 to bring back the `ariaOwneeID` prop. The ARIA property `aria-owns` is required for the combobox ARIA widget, in both ARIA 1.0 and 1.1. Some plugins, for example the Mentions and Emoji plugins, still pass an `ariaOwneeID` prop which at the moment doesn't do anything. Also, without `aria-owns`, some browser / screen reader combinations don't read out the suggestions at all. For more details please refer to the related issue facebookarchive#1736. Fixes facebookarchive#1736. Pull Request resolved: facebookarchive#1883 Reviewed By: vdurmont Differential Revision: D10371390 Pulled By: vdurmont fbshipit-source-id: 140282124128437e0d8cc9b08490420c3dc81dc1
1 parent 016293f commit 2115ff7

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

src/component/base/DraftEditor.react.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -378,6 +378,7 @@ class DraftEditor extends React.Component<DraftEditorProps, State> {
378378
aria-label={this.props.ariaLabel}
379379
aria-labelledby={this.props.ariaLabelledBy}
380380
aria-multiline={this.props.ariaMultiline}
381+
aria-owns={readOnly ? null : this.props.ariaOwneeID}
381382
autoCapitalize={this.props.autoCapitalize}
382383
autoComplete={this.props.autoComplete}
383384
autoCorrect={this.props.autoCorrect}

src/component/base/DraftEditorProps.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ export type DraftEditorProps = {
100100
ariaLabel?: string,
101101
ariaLabelledBy?: string,
102102
ariaMultiline?: boolean,
103+
ariaOwneeID?: string,
103104

104105
webDriverTestID?: string,
105106

0 commit comments

Comments
 (0)