Skip to content

Conversation

@bgub
Copy link
Contributor

@bgub bgub commented Feb 9, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I'm a maintainer of https://npmjs.com/package/npm-to-yarn, which is used by docusaurus-remark-plugin-npm2yarn.

Previously, npm-to-yarn didn't work correctly with NodeNext module resolution. The newest version fixes that.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

See bgub/npm-to-yarn#33

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 9, 2023
@bgub
Copy link
Contributor Author

bgub commented Feb 9, 2023

Not sure if I should push yarn.lock or not.

@netlify
Copy link

netlify bot commented Feb 9, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit ef2cdf2
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63f38bb5946f6000089741a4
😎 Deploy Preview https://deploy-preview-8650--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 83 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 77 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena
Copy link
Collaborator

Not sure if I should push yarn.lock or not.

Yes, please

@Josh-Cena Josh-Cena changed the title Update version of npm-to-yarn chore: bump npm-to-yarn Feb 10, 2023
@Josh-Cena Josh-Cena added the pr: dependencies Pull requests that update a dependency file label Feb 10, 2023
@bgub
Copy link
Contributor Author

bgub commented Feb 10, 2023

@Josh-Cena just pushed it.

@slorber
Copy link
Collaborator

slorber commented Feb 15, 2023

LGTM but maybe we could wait a bit for this PR to land first as we'll benefit from it soon?

bgub/npm-to-yarn#36

@armano2
Copy link
Contributor

armano2 commented Feb 19, 2023

fixes #5861

@bgub
Copy link
Contributor Author

bgub commented Feb 20, 2023

I just updated the PR to require [email protected], which includes bgub/npm-to-yarn#36 as well as bgub/npm-to-yarn#37

@slorber
Copy link
Collaborator

slorber commented Feb 22, 2023

Closing in favor of #8690

@slorber slorber closed this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants