Skip to content

Conversation

@dawei-wang
Copy link
Contributor

@dawei-wang dawei-wang commented Dec 15, 2022

Fixes #8369
Issue fix: To prevent content container growth, to take all the available space.

Pre-flight checklist

  • [v ] I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

https://deploy-preview-8442--docusaurus-2.netlify.app/
https://deploy-preview-8442--docusaurus-2.netlify.app/tests/docs/doc-with-another-sidebar

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 15, 2022
@netlify
Copy link

netlify bot commented Dec 15, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 7772618
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/639e7a86021b58000945f1c0
😎 Deploy Preview https://deploy-preview-8442--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Dec 15, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 83 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 77 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena
Copy link
Collaborator

@dawei-wang Normally I won't be reviewing CSS changes, but just want to drop by and say hi—nice seeing you here as well 😄

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we don't want to un-necessarily push the footer outside the full viewport height 😅

I want to see the full footer in the viewport here, and not having to scroll to see it.

https://deploy-preview-8442--docusaurus-2.netlify.app/tests/docs/doc-with-another-sidebar

CleanShot 2022-12-15 at 13 35 54

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Dec 15, 2022
@slorber slorber marked this pull request as draft December 15, 2022 12:38
@dawei-wang dawei-wang marked this pull request as ready for review December 18, 2022 02:29
@slorber
Copy link
Collaborator

slorber commented Dec 22, 2022

Closing in favor of #8463

@slorber slorber closed this Dec 22, 2022
@dawei-wang dawei-wang deleted the fix-8369 branch December 22, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs layout issue: content container does not grow to take all the available space

4 participants