Skip to content

Conversation

@homotechsual
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Clarifies currently undocumented behaviour of the tag types.

@homotechsual homotechsual requested a review from slorber as a code owner November 5, 2022 19:34
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 5, 2022
@netlify
Copy link

netlify bot commented Nov 5, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit ac6462f
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6366bad1bfc0ac0009f26761
😎 Deploy Preview https://deploy-preview-8292--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Nov 5, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 83 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 84 🟢 100 🟢 100 🟢 100 🟢 90 Report

@netlify
Copy link

netlify bot commented Nov 5, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit f426e81
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6366bb37b94c330008e7dc59
😎 Deploy Preview https://deploy-preview-8292--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 9, 2022
@slorber
Copy link
Collaborator

slorber commented Nov 9, 2022

👍 thanks

@slorber slorber merged commit 7ffa9f7 into facebook:main Nov 9, 2022
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants