Skip to content

fix(theme-classic): hamburger menu control navigation by keyboard #8207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slorber merged 2 commits into from
Oct 19, 2022
Merged

fix(theme-classic): hamburger menu control navigation by keyboard #8207

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cc42a1
fix(theme-classic): hamburger menu control navigation by keyboard
jeferson-sb Oct 12, 2022
14f4f89
feat(theme-classic): add translations for mobile menu button
jeferson-sb Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/docusaurus-theme-classic/src/theme/Navbar/MobileSidebar/Header/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ function CloseButton() {
return (
<button
type="button"
aria-label="Close navigation bar"
className="clean-btn navbar-sidebar__close"
onClick={() => mobileSidebar.toggle()}>
<IconClose color="var(--ifm-color-emphasis-600)" />
Expand Down
9 changes: 4 additions & 5 deletions packages/docusaurus-theme-classic/src/theme/Navbar/MobileSidebar/Toggle/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,14 @@ import {useNavbarMobileSidebar} from '@docusaurus/theme-common/internal';
import IconMenu from '@theme/Icon/Menu';

export default function MobileSidebarToggle(): JSX.Element {
const mobileSidebar = useNavbarMobileSidebar();
const {toggle, shown} = useNavbarMobileSidebar();
return (
<button
onClick={mobileSidebar.toggle}
onKeyDown={mobileSidebar.toggle}
onClick={toggle}
aria-label="Navigation bar toggle"
aria-expanded={shown}
className="navbar__toggle clean-btn"
type="button"
tabIndex={0}>
type="button">
<IconMenu />
</button>
);
Expand Down