fix(theme): announce theme switches #8174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mturoci
changed the title
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
Collaborator
|
Hey Just learned VoiceOver 101 to test this 😄 What I understand is that before the aria-label would be read again but not on space / enter, but only when pressing voiceover ctrl+opt+space After this change it announce the chance with both space / enter / ctrl+opt+space so it looks better to me 👍 Also reading aria-live docs, that seems like an appropriate usage to me 👍 Thanks |
slorber
added
pr: bug fix
⚡️ Lighthouse report for the deploy preview of this PR
|
Josh-Cena
changed the title
Collaborator
|
I think there's a remaining issue so re-opened there: #7667 (comment) |
slorber
added a commit
that referenced
this pull request
Oct 28, 2022
…8174) Co-authored-by: sebastienlorber <[email protected]>
slorber
added
backported
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Added
aria-liveattribute that indicates the element will be updated in future. This effectively solves issue as the originalaria-labelis read on every button submission, compared to be read just once as before.Test Plan
Manual testing using VoiceOver screen reader on MacOS.
Test links
Deploy preview: https://deploy-preview-8174--docusaurus-2.netlify.app/
Related issues/PRs
Closes #7667