Run yarn during ejecting to avoid hoisting issues and fix CI
#3806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could never get this working on windows: #3347 |
Contributor
Author
|
We somehow run Yarn from Create React App itself, don't we? So maybe we could run it in the same way? |
Contributor
Author
|
If this passes Travis but doesn't work on Windows we'll debug further with @BYK tomorrow. |
Contributor
Author
|
Ooh maybe this is because we delete |
Contributor
Author
|
For future reference, what likely happens here is that running |
gaearon
force-pushed
the
fix-ci
branch
2 times, most recently
from
5a00671 to
5bc562a
Compare
Contributor
Author
|
This works. Travis has some temporary issues but they're not our fault. |
This was referenced Jan 16, 2018
gaearon
changed the title
yarn during ejecting to avoid hoisting issues and fix CI
akstuhl
pushed a commit
to akstuhl/create-react-app
that referenced
this pull request
Mar 15, 2018
* Try to fix CI * Bump Jest elsewhere * Bump Babel elsewhere * Fix CI on Windows by writing .cmd file back
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Sep 30, 2018
* Try to fix CI * Bump Jest elsewhere * Bump Babel elsewhere * Fix CI on Windows by writing .cmd file back
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI started failing, possibly after Jest released a 21.1.0 update.
After chatting to @BYK our best guess is that because we didn't re-run Yarn after ejecting, the new script location (in the root
/scriptsfolder rather than innode_modules/react-scripts/scripts) started picking up a differentbabel-coreversion that was previously being hoisted (6.x judging by the stack trace that has/lib/in it) than the onereact-scriptswanted (7.0 bridge).Our current behavior always seemed weird to me (#3356), and now that it's possibly causing bugs, I think we should try getting rid of that special case. Perhaps those issues in the TODO are not relevant anymore, or maybe we can find better fixes for them. Conceptually re-running yarn sounds like the only right thing to do.
I'm kind of shooting in the dark here so I also tried to update other Jest packages while we're at it.