Skip to content

Adjust the checkIfOnline check if in a corporate proxy environment #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Timer merged 2 commits into from
Aug 9, 2017
Merged

Adjust the checkIfOnline check if in a corporate proxy environment #2884

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
235739e
Adjust the `checkIfOnline` check if in a corporate proxy environment
bsyk Aug 2, 2017
99c4ab1
Adjust to check yarnpkg.com first, then check the proxy address only …
bsyk Aug 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/create-react-app/createReactApp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ const semver = require('semver');
const dns = require('dns');
const tmp = require('tmp');
const unpack = require('tar-pack').unpack;
const url = require('url');
const hyperquest = require('hyperquest');

const packageJson = require('./package.json');
Expand Down Expand Up @@ -613,7 +614,13 @@ function checkIfOnline(useYarn) {
}

return new Promise(resolve => {
dns.lookup('registry.yarnpkg.com', err => {
let host = 'registry.yarnpkg.com';
// If a proxy is defined, we likely can't resolve external hostnames.
// Try to resolve the proxy name as an indication of a connection.
if (process.env.https_proxy) {
host = url.parse(process.env.https_proxy).hostname;
}
dns.lookup(host, err => {
resolve(err === null);
Copy link
Contributor

@Timer Timer Aug 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here, this strict equality in this case makes me uncomfortable -- can we do == null?

});
});
Expand Down