Skip to content

Conversation

@DavidIsrawi
Copy link

Issue
The deployments were referring to the master branch for the GitHub Pages documentation (which is now outdated)

Fix
Changed references to main

Notes
I was thinking of adding a disclaimer so people with an old repo were able to follow with master instead of main but ultimately decided not to add it. Let me know if you think we should

@facebook-github-bot
Copy link

Hi @DavidIsrawi!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@DavidIsrawi
Copy link
Author

Let me know if there's anything else I should add for this PR! @iansu @mrmckeb

@matrush
Copy link
Contributor

matrush commented Jun 17, 2022

Thanks! Fixed in #10696

@matrush matrush closed this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants