Skip to content

Fix CI docker compose and clippy errors#450

Merged
afterdusk merged 2 commits intofacebook:mainfrom
afterdusk:ci-fix
Aug 23, 2024
Merged

Fix CI docker compose and clippy errors#450
afterdusk merged 2 commits intofacebook:mainfrom
afterdusk:ci-fix

Conversation

@afterdusk
Copy link
Member

To address the following error on GitHub Actions test running job:
image

The issue and fix is described here,

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (3ce5335) to head (45c8071).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
- Coverage   88.61%   88.04%   -0.57%     
==========================================
  Files          39       38       -1     
  Lines        9109     8282     -827     
==========================================
- Hits         8072     7292     -780     
+ Misses       1037      990      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afterdusk
Copy link
Member Author

Added fixes for clippy issues.

@afterdusk afterdusk changed the title Fix CI docker compose error Fix CI docker compose and clippy errors Aug 23, 2024
Copy link
Contributor

@dillongeorge dillongeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning this up!

@afterdusk afterdusk merged commit 2302666 into facebook:main Aug 23, 2024
@afterdusk afterdusk deleted the ci-fix branch August 23, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants