Updating generated test vectors#448
Merged
kevinlewi merged 1 commit intofacebook:mainfrom Aug 23, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
==========================================
- Coverage 88.61% 88.03% -0.59%
==========================================
Files 39 38 -1
Lines 9109 8282 -827
==========================================
- Hits 8072 7291 -781
+ Misses 1037 991 -46 ☔ View full report in Codecov by Sentry. |
6e45544 to
5186ef2
Compare
afterdusk
approved these changes
Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR regenerates the test vectors (which were out of date after the latest change to lookup + history proof generation).
Also adds a test which will fail next time if the logic is updated and out-of-sync with the test vectors (prompting the developer to manually re-generate the test vectors) using the command in https://github.com/facebook/akd/blob/main/examples/README.md