Skip to content

Updating generated test vectors#448

Merged
kevinlewi merged 1 commit intofacebook:mainfrom
kevinlewi:update_test_vectors
Aug 23, 2024
Merged

Updating generated test vectors#448
kevinlewi merged 1 commit intofacebook:mainfrom
kevinlewi:update_test_vectors

Conversation

@kevinlewi
Copy link
Contributor

This PR regenerates the test vectors (which were out of date after the latest change to lookup + history proof generation).

Also adds a test which will fail next time if the logic is updated and out-of-sync with the test vectors (prompting the developer to manually re-generate the test vectors) using the command in https://github.com/facebook/akd/blob/main/examples/README.md

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (3ce5335) to head (5186ef2).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
- Coverage   88.61%   88.03%   -0.59%     
==========================================
  Files          39       38       -1     
  Lines        9109     8282     -827     
==========================================
- Hits         8072     7291     -781     
+ Misses       1037      991      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kevinlewi kevinlewi force-pushed the update_test_vectors branch from 6e45544 to 5186ef2 Compare August 23, 2024 18:16
@kevinlewi kevinlewi marked this pull request as ready for review August 23, 2024 18:59
@kevinlewi kevinlewi requested a review from dillongeorge August 23, 2024 18:59
@kevinlewi kevinlewi merged commit ebf407a into facebook:main Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants