Adding test vector generation example#445
Merged
kevinlewi merged 1 commit intofacebook:mainfrom Jul 18, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #445 +/- ##
==========================================
- Coverage 88.61% 87.88% -0.73%
==========================================
Files 39 38 -1
Lines 9109 8165 -944
==========================================
- Hits 8072 7176 -896
+ Misses 1037 989 -48 ☔ View full report in Codecov by Sentry. |
dillongeorge
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a new example (under examples/) for producing the hex-encoded byte representations of lookup and key history proofs.
This will allow other implementations to compare against and exercise protobuf deserialization / parsing in the event that there is another client-side implementation which can consume lookup and history proofs for verification.