Skip to content

Anchor mysql version to 8.4#443

Merged
afterdusk merged 2 commits intofacebook:mainfrom
afterdusk:mysql-fix
Jul 8, 2024
Merged

Anchor mysql version to 8.4#443
afterdusk merged 2 commits intofacebook:mainfrom
afterdusk:mysql-fix

Conversation

@afterdusk
Copy link
Member

In #433, we updated our docker-compose.yaml to use a startup argument relevant to the then latest mysql version (8.4).

However this startup argument is deprecated in the current latest version of mysql (9.0). I have not had time to understand what changes need to be made to be compatible - for now, let's set the mysql version to 8.4 to fix CI and unblock local development. We will upgrade to a more recent version when we are ready.

I also drop the version attribute from the docker-compose.yaml, since it is obsolete and produces a warning when used.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 8, 2024
@afterdusk
Copy link
Member Author

Added one more commit to rename .cargo/config to .cargo/config.toml, to address the warning that runs on every cargo invocation:

warning: `akd/.cargo/config` is deprecated in favor of `config.toml`

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.92%. Comparing base (3ce5335) to head (de8d4ca).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #443      +/-   ##
==========================================
- Coverage   88.61%   87.92%   -0.70%     
==========================================
  Files          39       38       -1     
  Lines        9109     8165     -944     
==========================================
- Hits         8072     7179     -893     
+ Misses       1037      986      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afterdusk afterdusk merged commit 54608f9 into facebook:main Jul 8, 2024
@afterdusk afterdusk deleted the mysql-fix branch July 8, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants