Merged
Conversation
eozturk1
approved these changes
Jul 8, 2024
Member
Author
|
Added one more commit to rename |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #443 +/- ##
==========================================
- Coverage 88.61% 87.92% -0.70%
==========================================
Files 39 38 -1
Lines 9109 8165 -944
==========================================
- Hits 8072 7179 -893
+ Misses 1037 986 -51 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #433, we updated our
docker-compose.yamlto use a startup argument relevant to the then latest mysql version (8.4).However this startup argument is deprecated in the current latest version of mysql (9.0). I have not had time to understand what changes need to be made to be compatible - for now, let's set the mysql version to 8.4 to fix CI and unblock local development. We will upgrade to a more recent version when we are ready.
I also drop the
versionattribute from thedocker-compose.yaml, since it is obsolete and produces a warning when used.