Add documentation around HistoryParams insecure options#428
Merged
kevinlewi merged 1 commit intofacebook:mainfrom Mar 24, 2024
Merged
Add documentation around HistoryParams insecure options#428kevinlewi merged 1 commit intofacebook:mainfrom
kevinlewi merged 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
==========================================
- Coverage 88.43% 88.34% -0.09%
==========================================
Files 39 39
Lines 9198 9180 -18
==========================================
- Hits 8134 8110 -24
- Misses 1064 1070 +6 ☔ View full report in Codecov by Sentry. |
dillongeorge
approved these changes
Mar 24, 2024
Hemmikuhschlemur
left a comment
Hemmikuhschlemur
left a comment
There was a problem hiding this comment.
What would be a main purpose of this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non-complete history options offered in the HistoryParams struct are insecure and should not be used for production purposes. This change adds these caveats to the docs.