Invalid fiscal code because municipality (birthplace) was activated after birthdate

[patrickt-oforce]

Python version
3.10

Package version
latest

Current behavior (bug description)
When try to validate the fiscal code DBRGRZ53R66F059C the library return it is not valid, instead the AdE checker say it is valid; i think this is due because the birthdate is before the municipalities activation date

Can be verified here: https://telematici.agenziaentrate.gov.it/VerificaCF/VerificaCf.do

Expected behavior
The DBRGRZ53R66F059C fiscal code should be valid

[fabiocaccamo]

@patrickt-oforce thank you for reporting this issue.

[patrickt-oforce]

Hi @fabiocaccamo i've tried to return the birthplace options if the municipality is currently active; but this break the base test suite for encoding_birthplace; where is tested if Torino is active on 01/01/1988 date; have you any suggestion?

[fabiocaccamo]

@patrickt-oforce I believe the cause is the same as in #210: some codes were assigned after the birthdate, and the municipality was not yet active at the time of birth.

[fabiocaccamo]

@patrickt-oforce the solution would be to add a fallback for returning the first matching municipality activated after the birthdate.

[patrickt-oforce]

Maybe the same; but checking file municipalities.json there is only one entry for F059 and the municipality was activeted in 1955 but the cf owner was birth in 1953; i've checked the municipalities-patch.json file and if i understand correctly a possible fix is to add a patch for Mattinata municipality, but which activation date should be used?

[patrickt-oforce]

@patrickt-oforce the solution would be to add a fallback for returning the first matching municipality activated after the birthdate.

Hi Fabio, where i can find the data about municipality activation after a birth date? i've checked the municipalities source file but for the F059 code ther is only one entry, not multiple like F060

[fabiocaccamo]

@patrickt-oforce anyway the issue is the same: the municipality did not yet exist on the birth date indicated in the code.