Add 'sort' parameter to keypaths()#467
Merged
fabiocaccamo merged 1 commit intofabiocaccamo:mainfrom Jan 18, 2025
kotfu:main
Merged
Add 'sort' parameter to keypaths()#467fabiocaccamo merged 1 commit intofabiocaccamo:mainfrom kotfu:main
fabiocaccamo merged 1 commit intofabiocaccamo:mainfrom
kotfu:main
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 63 63
Lines 2011 2012 +1
=======================================
+ Hits 1966 1967 +1
Misses 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fabiocaccamo
approved these changes
Jan 18, 2025
Owner
fabiocaccamo
left a comment
fabiocaccamo
left a comment
There was a problem hiding this comment.
@kotfu thank you for this nice PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull request
about: Submit a pull request for this project
assignees: fabiocaccamo
Describe your changes
The
keypaths()function sorts the list before returning it. There are use cases where an unsorted list is useful. Added asortparameter which defaults toTruefor backwards compatability. Added unit test, and updated README. This PR based on a patch from @mucmch.Related issue
#404.
Checklist before requesting a review
I also updated the documentation in
README.mdto show this new parameter.