Skip to content

Conversation

@neutrinoceros
Copy link
Contributor

Hi, thanks a lot for this project, I find this amazing.

I propose adding a little info whenever KeyError is raised, mimicking the built-in dictionary class.

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #28 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files          50       50           
  Lines        1236     1247   +11     
=======================================
+ Hits         1226     1237   +11     
  Misses         10       10           
Impacted Files Coverage Δ
benedict/core/move.py 100.00% <100.00%> (ø)
benedict/dicts/keylist/keylist_dict.py 100.00% <100.00%> (ø)
benedict/dicts/keylist/keylist_util.py 100.00% <100.00%> (ø)
benedict/dicts/io/io_dict.py 100.00% <0.00%> (ø)
benedict/dicts/keypath/keypath_dict.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 769cd88...dfc79a4. Read the comment docs.

@fabiocaccamo fabiocaccamo self-assigned this Sep 7, 2020
@fabiocaccamo fabiocaccamo merged commit 4d6c43d into fabiocaccamo:master Sep 10, 2020
@neutrinoceros neutrinoceros deleted the keyerror_explicit branch September 10, 2020 16:57
@neutrinoceros
Copy link
Contributor Author

Thanks for merging ! If you're curious, I'm pondering on the idea of using benedict for field accessing in Yt (https://github.com/yt-project/yt/)
I might have related questions and/or PRs in the future, is it okay to open issues to ask questions ?

@fabiocaccamo
Copy link
Owner

You're welcome, it will be a plaisure if you decide to use python-benedict in Yt.
Sure, feel free to open new issues and/or submit PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants