Bug: Passing `data_only=True` into `from_xls()` returns excel formulas instead of cell data values

[kartzke]

Python version
Python 3.11.6

Package version
python-benedict 0.33.0

Current behavior (bug description)
Using the following code, benedict returns a dictionary with raw cell values, including formulas. Even though the data_only=True kwarg is passed into the constructor.

from benedict import benedict

content = benedict.from_xls("src/data/content.xlsx", sheet="Sheet3", data_only=True)
print(content)

Expected behavior
I believe benedict should return the data values instead of formulas. So it should return 'formula': 'A2 value is: abc' instead of 'formula': '="A2 value is: "&A2'.

I'm expecting this because it's an xlsx file, which the docs say uses openpyxl to fetch the data, and I'm passing the data_only=True kwarg into the constructor. If I try to access this data directly in openpyxl, it correctly returns the data values.

If I'm misunderstanding something about the way this is supposed to work, please let me know. :)

from openpyxl import open

wb = open("src/data/content.xlsx", data_only=True)
for i in wb['Sheet3'].values:
    print(i)

[fabiocaccamo]

@kartzke thanks for reporting this issue, could you also upload the xls file please?

[kartzke]

@fabiocaccamo Sure thing, the workbook is attached, it has one row of data to demonstrate the issue

content.xlsx

[fabiocaccamo]

@kartzke fixed in 0.33.1 version.

[kartzke]

Thanks @fabiocaccamo! I just tested 0.33.1 on my local, the fix works for me.

I discovered benedict last month, it's an awesome python package, great work on it 🙂

[fabiocaccamo]

Thanks @kartzke !! I'm really glad you appreciate it!