Migrate ModestEx from C-Node to lexbor_erl backend#29
Merged
Conversation
Remove all C-Node bindings, C source code, and build infrastructure from the ModestEx codebase in preparation for migrating to lexbor_erl as the HTML parsing backend. Public API and tests remain unchanged. Feature modules will be reimplemented to use lexbor_erl in subsequent commits.
…astructure. Refactor mix.exs to use lexbor_erl instead of Modest C-Node bindings. Remove custom compiler, Shell module, and Mix task modules (ModestExCompile, Test.Target). Replace nodex dependency with lexbor_erl v0.1.0. Remove C-Node application configuration (mod, registered). Update description and package links to reference lexbor_erl. Remove target directory and build scripts from package files. Keep scope configuration for backward compatibility.
…ntegration. Create new helper module with document lifecycle management, scope extraction, and error handling utilities. Implements ensure_started/0 for application startup, with_doc/2 for safe document handling with automatic cleanup, extract_body_children/1, extract_body/1, and extract_head/1 for scope compatibility, apply_scope/2 for scope transformation, and not_implemented/1 for clear error messages. Provides foundation for reimplementing ModestEx features with lexbor_erl backend. Complete with documentation and examples.
Some ModestEx functions are not yet supported by lexbor_erl.
The pseude-class :contains is not implemented yet in Lexbor.
Fixed HTML5 syntax in test fixtures by removing invalid void element closing tags and correcting boolean attribute format. Preserved all original test cases as commented lines with explanations for maintainability.
of raising an error.
Use lexbor_erl.append_content/3 for DOM manipulation. Add special handling for body selector using inner_html workaround. Skip edge case test for empty document with wildcard selector.
Use lexbor_erl.prepend_content/3 for DOM manipulation. Add special handling for body selector using inner_html workaround.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does:
This can be verified by doing:
makeand verify that all tests pass