Skip to content

Conversation

@ayakut16
Copy link
Contributor

@ayakut16 ayakut16 commented May 1, 2025

Description

There is no official sdk for go yet and https://github.com/mark3labs/mcp-go seems to be the most popular one, so I think there is no need for us to maintain transport & client logic which causes many issues.

I haven't tested the individual issues yet but I believe #47 #48 will be fixed with this PR.

Type of change

Please delete options that are not relevant.

  • Migration

How Has This Been Tested?

Tried out all commands + unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ayakut16 ayakut16 force-pushed the migration/client branch from 4232de4 to fae59c5 Compare May 1, 2025 16:56
@f
Copy link
Owner

f commented May 2, 2025

omg that's so cool!

@f
Copy link
Owner

f commented May 2, 2025

When a server doesn't have prompts/resources but run it fails now:

Screenshot 2025-05-02 at 12 53 51

@f
Copy link
Owner

f commented May 2, 2025

Created a PR for your PR: ayakut16#1

@ayakut16
Copy link
Contributor Author

ayakut16 commented May 2, 2025

When a server doesn't have prompts/resources but run it fails now:

Good catch ! Thanks for the fix.

@f f merged commit f6d5ce5 into f:master May 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants