docs(readme): Update deb instructions to use keyring #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gierens
requested changes
Sep 15, 2023
gierens
requested changes
Sep 15, 2023
trusted.gpg.d requires de-armored keys on some systems (Ubuntu 20.04) and ASCII-armored keys on others (Debian 12)
Signed-off-by: Sandro-Alessio Gierens <[email protected]>
Signed-off-by: Sandro-Alessio Gierens <[email protected]>
gierens
approved these changes
Sep 16, 2023
There was a problem hiding this comment.
I changed to chmod 644 to make the command more general and added possible gpg installation instructions as some systems don't ship it by default (Debian 11/12) cloud images for example.
@cafkafk I've tested this on Ubuntu 20, 22 and Debian 11, 12 VMs. Works! Approved! Ready for merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trusted.gpg.d requires de-armored keys on some systems (Ubuntu 20.04) and ASCII-armored keys on others (Debian 12)
this keyring method works on both systems. I tested in an ubuntu:20.04 container and a debian:12 container
it also uses
dd of=instead ofteeto avoid dumping binary to the terminalfixes #259