Skip to content

Conversation

@MartinFillon
Copy link
Contributor

As mentionned in issue #279 we need to improve test dir, which I did, I just need your help to regenerate the current nix and windows test to better match the new dir that is tested

@cafkafk cafkafk mentioned this pull request Sep 12, 2023
12 tasks
MartinFillon and others added 3 commits September 13, 2023 05:52
Added:
Symlinks and broken link
Files with multiple extensions
Directories with files

Breaking Changes:
TEST cannot be run for the moment on this commit.
Made unix and all tests adapted to the new directory
Signed-off-by: Christina Sørensen <[email protected]>
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to change commit summaries from tests -> test. Regenerated nix tests.

This can merge when someone regenerates windows tests as mentioned.

@MartinFillon
Copy link
Contributor Author

Maybe @Stetsed could help on that pr for the windows part

@MartinFillon
Copy link
Contributor Author

@cafkafk Windows is done 😄

Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okai, cool, for some reason CI doesn't run on this, I'll have to fix that somehow... but lgtm 👍

@cafkafk cafkafk merged commit 1e7ecea into eza-community:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants