Skip to content

Conversation

@daviessm
Copy link
Contributor

@daviessm daviessm commented Aug 27, 2023

I don't have a Mac to test on, I'd appreciate it if someone could check that build out too. This branch currently builds on both Windows and Linux.

Fixes #169
Fixes #102

@cafkafk
Copy link
Member

cafkafk commented Aug 28, 2023

Looks like this failed on MacOS https://github.com/eza-community/eza/actions/runs/5991795977/job/16263711309?pr=171

I added windows to the CI, so when windows support is working and this merges, it will keep working (hopefully).

@daviessm
Copy link
Contributor Author

Thanks @cafkafk, I pushed a couple of fixes but without a Mac I'm shooting in the dark. Can you give the CI another run (probably just the macos one, if that works then the rest can run as well)?

Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This merges the #173 changes in, so we can ensure they also work on windows.

Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passes, and initial testing on x86_64 GNU/Linux indicates this is working as expected. Can someone verify this works on Windows/Mac?

@daviessm
Copy link
Contributor Author

daviessm commented Sep 3, 2023

Windows build looks fine to me. Perhaps @cfxegbert could test this branch on Mac?

@cafkafk
Copy link
Member

cafkafk commented Sep 3, 2023

I guess we'll just test this live, I feel like it's reasonable to expect it's also working on mac, if not people will probably be quick to open an issue about it.

@cafkafk cafkafk merged commit 8edf1a8 into eza-community:main Sep 3, 2023
@daviessm daviessm deleted the fix_windows_build branch September 5, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

ci: Windows build is broken after afeac47 (#61) Windows Support

2 participants