fix: select secretstores in same ns as pushsecret #5109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grace Do <[email protected]>
gracedo
force-pushed
the
gracedo/fix_ps_ss_scope
branch
from
e07e526 to
61e6ddf
Compare
Contributor
|
/ok-to-test sha=61e6ddf949c8f61b8f0ff5912fe2731a13380912 |
Contributor
|
|
Member
|
/ok-to-test sha=5423347c7a480512433ca085af51f0e6a9f1cba2 |
Contributor
moolen
approved these changes
Aug 12, 2025
Member
moolen
left a comment
moolen
left a comment
There was a problem hiding this comment.
Thank you for fixing this issue 🙇, really appreciated!
There's another issue with r.List() in pushsecret_controller which should be scoped to a namespace, thanks for raising this.
1 task
alliseeisgold
pushed a commit
to alliseeisgold/external-secrets
that referenced
this pull request
Aug 25, 2025
) Signed-off-by: Grace Do <[email protected]> Co-authored-by: Gergely Brautigam <[email protected]> Co-authored-by: Moritz Johner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
PushSecretsdefining label selectors to selectSecretStoresare trying to selectSecretStoresfrom all namespaces, instead of the same namespace as thePushSecret. This causes errors reconciling thePushSecretas it attempts to get theseSecretStoresin the same namespace but they don't exist.Related Issue
Proposed Changes
When listing
SecretStoresby label selector, thenamespaceoption should be passed in to only getSecretStoresin the same namespace as thePushSecret.Checklist
git commit --signoffmake testmake reviewable