Skip to content

Conversation

@yanganto
Copy link

Remove average dependency in server crate

Description

Remove average dependency and implement without additional crate

Motivation and Context

This refactor PR follow the TODO hint in the code.
Two facts about this refactor.

  • Macro takes compiling time, and we use average crate macro, but the lines of code does not significantly reduce.
  • The macro implement inline functions to avoid performance costs, but the fn new will call the default functions, and these are not inline functions.
    https://docs.rs/average/latest/src/average/macros.rs.html#129

How Has This Been Tested?

This refactor obey the current test cases.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • The correct base branch is being used, if not main

@yanganto yanganto requested a review from a team as a code owner November 10, 2025 08:03
Copy link
Contributor

@kp-mariappan-ramasamy kp-mariappan-ramasamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the parameters are same as the 1.0.4 delivery configs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants