add deprecation warnings for redirect arguments undefined #6405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlisesGascon
approved these changes
Mar 19, 2025
Member
|
I added a warning message in the description to prevent early merges 👍 |
Member
Author
|
I think it should be the other way around—this should be merged first before #6404, since it needs to be deprecated in v5 first for the effect to result in throwing errors in v6. Does that make sense? |
Member
Author
|
@wesleytodd @UlisesGascon @expressjs/express-collaborators Any objections to releasing this in the next minor version of Express? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛑 No Merge before #6404 has landed in v6
With this, those arguments are deprecated when they are undefined or different from their data type
Related #6404
Closes #6391