#3867 docs: update the example in the readme so that it uses const instead of var #3868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I just want to say that I am lukewarm on these kind of updates. I feel like it is fine and well to follow common developer practices with the examples, but I don't see a lot of value in changing perfectly functional examples. This is coming from someone who does define my imports as |
|
Looks good 😃 |
Contributor
|
@wesleytodd I don't really care for these either, but since it does work on our target Node.js versions and perhaps will stop this particular PR in the future, I may as well merge it in. |
dougwilson
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3867